Need help to find error in collision dection in XNA

Question

I really need some help to find the reason why not any of my Asteroids sprites are visible on the screen after I added som code to dedect collision. My suspect is that it has to do in the collision method and that the sprites are removed from the list from the beginning!? The Spaceship is visible.

In my manager class I have this method for checking the collision:

public void CollisionControl(Spaceship spaceShip)
    {
        for (int i = 0; i < asteroidList.Count(); i++)
        {
            if (asteroidList.ElementAt(i).Bounds().Intersects(spaceShip.Bounds()))
            {
                asteroidList.RemoveAt(i);
                i--;
            }
        }
    }

And then from the Game1 class I call this manager from the Update Method like this:

 asteroidManager.CollisionControl(spaceship);

And finally in the SpaceShip class and the Asteroids Class I have this code:

// Bounds
    public Rectangle Bounds()
    {
        //return new Rectangle((int)(position.X - orgin.X), (int)(position.Y - orgin.Y), texture.Width, texture.Height);
        return new Rectangle(0,0,60,60);
    }

// Draw method
    public void Draw(SpriteBatch spriteBatch)
    {
        //spriteBatch.Draw(texture, position, new Rectangle(0,0, (int)texture.Width, (int)texture.Height) , Color.White, rotation, orgin, 1, SpriteEffects.None, 0);
        spriteBatch.Draw(texture, position, null, Color.White, rotation, orgin, 1, SpriteEffects.None, 0);
    }

Help is really preciated! I'm doing a hand in task that I need to complete soon! Thanks!

Answer 1

Do you ever move the bounds? If not, then all the rectangles are always at 0, 0, 60, 60 and always intersecting. You need to move the bounds to the location of your ship/asteroid:

public Rectangle Bounds()
{
    int width = 60;
    int height = 60;

    int x = position.X - (width/2);
    int y = position.Y - (height/2);

    return new Rectangle(x, y, width, height);
}

Answer 2

You are not updating your rectangle, however you do not want to be creating it every test so you could when you set up the class create the rectangle.

public Spaceship() {
  rectangle = new Rectangle(position.X, position.Y, 60, 60);
}

then call bounds but update x and y before returning

public Rectangle Bounds()
{
    rectangle.X = position.X - (width/2);
    rectangle.Y = position.Y - (height/2);

    return rectangle;
}

this will avoid multiple objects being created and destroyed in your update part of game loop.