Is this bad design to have a static class which plays sound effects?

Question

I am trying to make a audio manager. I want this audio manager to setup itself and be accessible from everywhere. So I made a static class that creates the audio sources when you need them. Is this bad design?

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using NodeEditorFramework.Utilities;

public static class AudioManager {

    private static bool musicIsSetup;
    private static AudioSource musicSource;
    private static bool sfxIsSetup;
    private static AudioSource sfxSource;

    public static void ManualSetup()
    {
        SetupSFXSystem();
        SetupMusicSystem();
    }

    public static void PlaySFX(AudioClip clip)
    {
        if (!sfxIsSetup) SetupSFXSystem();
        sfxSource.PlayOneShot(clip);
    }

    public static void PlayMusic(AudioClip clip)
    {
        if (!musicIsSetup) SetupMusicSystem();
        musicSource.clip = clip;
        if (!musicSource.isPlaying) musicSource.Play();
    }

    private static void SetupMusicSystem()
    {
        musicIsSetup = true;
        GameObject MusicHandler = new GameObject("MusicHandler");
        musicSource = MusicHandler.AddComponent<AudioSource>();
    }

    private static void SetupSFXSystem()
    {
        sfxIsSetup = true;
        GameObject SFXHandler = new GameObject("SFXHandler");
        sfxSource = SFXHandler.AddComponent<AudioSource>();
    }
}

Answer 1

The main limitation I see with this class is that it can not handle positional audio. It creates two audio sources at unspecified coordinates, which means they will get spawned at 0:0:0. The audio listener in the scene, however (unless you change that) is attached to the main camera. So depending on the position of the camera, sound effects will become louder, quieter and change their stereo panning.

If all the sound effects you play through this class are meant to be non-diegetic (the sound is made by the user interface, not a particular object in the game world), then you should make the audio handlers children of the main camera (or whichever objects has your audio listener). If you want a sound effect to be diegetic, then they should be played through an audio source attached to the object which makes the sound.

If your main intention of the class is that you don't want to deal with audio sources, then it might be useful to add a method PlaySFX(AudioClip clip, GameObject source). The method should check if the source already has an AudioSource component, and when it has not, it adds one to it. It then plays the clip through the AudioSource of the game object. Your standard PlaySFX(AudioClip clip) method could then just call PlaySFX(clip, Camera.current.gameObject); to play a non-diegetic sound effect.

Another useful overload could be PlaySFX(AudioClip clip, Vector3 position) which creates an ephemeral game object with an AudioSource component at the given world-position which plays the clip and then self-destructs.