If statement works fine until I add a tag check requirement. Why is this?

Question

I'm trying to add a tag check to an if statement but for some reason when I add said tag check it stops working.

void Update ()
    {
        Vector3 fwd = transform.forward; // Equivalent to the code you had.

        Ray ray = new Ray(transform.position, transform.forward);
        RaycastHit hit;

        if (Input.GetMouseButton(0) && Physics.Raycast(ray, out hit, 10f) && isPlayerHolding == false && gameObject.CompareTag("Pickable"))
        {
                isPlayerHolding = true;
                hit.transform.SetParent(Player.transform);
                Debug.Log("We hit: " + hit.transform.name);
                hit.rigidbody.constraints = RigidbodyConstraints.FreezeRotation;
                hit.rigidbody.constraints = RigidbodyConstraints.FreezePosition;

        }
        if (Input.GetMouseButton(1) && Physics.Raycast(ray, out hit, 10f) && isPlayerHolding == true)
        {
            hit.transform.parent = null;
            isPlayerHolding = false;
            hit.rigidbody.constraints = RigidbodyConstraints.None;
        }

More specifically this is the bit of code that is holding things up "&& gameObject.CompareTag("Pickable")".

Things I've tried:

• Debugged variables in C# to be sure nothing is missing/null.
• Making sure the tag is setup properly within Unity.

I really can't think of what the problem is. Anyone have any ideas?

Answer 1

Are you trying to use CompareTag on the gameObject that your RaycastHit is returning? If so it looks like you would need to do "hit.collider.gameObject.CompareTag".

Or if that doesn't work, you would need to move that condition into a nested if statement. So:

if (Input.GetMouseButton(0) && Physics.Raycast(ray, out hit, 10f) && isPlayerHolding == false && hit.collider.gameObject.CompareTag("Pickable"))
    {
            isPlayerHolding = true;
            hit.transform.SetParent(Player.transform);
            Debug.Log("We hit: " + hit.transform.name);
            hit.rigidbody.constraints = RigidbodyConstraints.FreezeRotation;
            hit.rigidbody.constraints = RigidbodyConstraints.FreezePosition;

    }

Or else perhaps:

if (Input.GetMouseButton(0) && Physics.Raycast(ray, out hit, 10f) && isPlayerHolding == false)
    {
          if( hit.collider.gameObject.CompareTag("Pickable")
           {
            isPlayerHolding = true;
            hit.transform.SetParent(Player.transform);
            Debug.Log("We hit: " + hit.transform.name);
            hit.rigidbody.constraints = RigidbodyConstraints.FreezeRotation;
            hit.rigidbody.constraints = RigidbodyConstraints.FreezePosition;
           }
    }

Let me know if I am misunderstanding; it is not immediately clear to me what you're trying to determine has a "Pickable" tag.