Why does my 2d collision and movement not work properly?

Question

I'm trying to write(in c++ using sdl) a mario like game as in a tile based world with by pixel movement for the character and I've run into some problems I cannot seem to find the source of:

1.The player won't collide with the walls.

2.when moving through open space the player sometimes stops moving and then becomes unmovable in either direction.

I'm not sure where the problem is and I would love your help finding these issues and any advice in general is appreciated. thanks!

Here is all the code:

http://pastebin.com/FGxW2x3T //sorry I can only post two links cause I don't have 10 rep.

Here is the collision detection function and player input/movement functions. http://pastebin.com/jWaZPDBm

Answer 1

I was using SDL_Rect for my collision box. The x and y variables for an SDL_Rect are of type short and I was using a double for my velocity so my player.xPos and player.yPos(which are doubles) were not equal to the collision box's position because of lost decimal points when converting my double xVel to the int of collisionBox.x I assume.

Thank you Samaursa for the link to the guide on debugging this is how I found my issue!